Adjust width of highway=construction rendering #3580
Conversation
|
Here is a zip of the JOSM file (.osm.xml) that I made for testing. It includes all rendered types of construction=* and highway=* at different scales. There is also an area with construction=*_link roads, and areas of different difficult landcover colors for comparison to the highways: |
|
After checking some more areas of highway=construction, I realized that highway=construction without construction=* (i.e. construction is null) should render the same as construction = residential and unclassified, rather than as construction=road. The majority of roads are highway=residential or highway=unclassified (which render the same), so it makes sense to assume that highway=construction is one of these, if not otherwise specified. I've pushed a commit to fix this. Singapore, http://openstreetmap.org/#map=15/1.3862/103.9276 z15 Master z14 Master |
|
Just the bridge was tagged construction=motorway, the connecting roads were
just tagged highway=construction.
I’m not sure if we should add bridge and tunnel rendering. The tunnel
rendering would be particularly difficult to get right. But I will consider
if for the next PR, after this one is finished.
…On Sat, Dec 22, 2018 at 11:32 PM Jérémy Ragusa ***@***.***> wrote:
Why the bridge is in motorway colour ?
BTW, could you also add rendering of bridge (#398
<#398>) and
tunnel (#761
<#761>) for
construction roads or is it better to do it in separate PRs ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3580 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AoxshO0LIUqYskreC9DaIukuvsK5A_gNks5u7kKJgaJpZM4ZZox6>
.
|
|
Nice to see a PR for this issue. Better rendering for construction roads would be great! I would keep the difference between “road” and “residential”. What is rendered for construction should follow the rendering for existing roads – yet for consistency. |
|
The current PR does render construction=road and construction=residential
differently, as shown in the test renderings above.
The change was for highway=construction without any additional tags.
…On Sun, Dec 23, 2018 at 7:39 AM Lukas Sommer ***@***.***> wrote:
Nice to see a PR for this issue. Better rendering for construction roads
would be great!
I would keep the difference between “road” and “residential”. What is
rendered for construction should follow the rendering for existing roads –
yet for consistency.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3580 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AoxshIWNyqk7lmSkKsdSk2PjZPvLX5rJks5u7rSpgaJpZM4ZZox6>
.
|
|
@jeisenbe Maybe a little bit off-topic, but do you have any idea for possible rail/ tram/ subway under construction rendering avoiding current dot-rendering of them? Otherwise it propably will be colliding with planned grey borders (see #2872 (comment)) |
|
Perhaps we should open a new issue about that problem?
I’ll look into it after the holiday, once this PR is closed.
…On Mon, Dec 24, 2018 at 3:23 AM Tomasz Wójcik ***@***.***> wrote:
@jeisenbe <https://github.com/jeisenbe> Do you have any idea for possible
rail/ tram/ subway under construction rendering avoiding current
dot-rendering of them? Otherwise it propably will be colliding with planned
grey borders (see #2872 (comment)
<#2872 (comment)>
)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3580 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AoxshAVVHlIJLMC_GA9XYFjJITGhlpdZks5u78ougaJpZM4ZZox6>
.
|
Fixed link roads; remove unsupported construction=* types Also added raceway, pedestrian, living_street, road as types of other construction roads Reduce width for narrow construction highway Add paths construction name label rendering Add construction=track name label rendering Add name label for construciton=null Adjust width of construction=secondary_link at z16
Highway=construction with construction=null was set to render the same as construction=road; thinner and later than construction=residential and construction=classified. Since highway=residential (and the identical highway=unclassified) are by far the most common type of road, it is proposed to render highway=construction at the same levels and width if there is no construciton=* tag
jeisenbe
force-pushed
the
construction
branch
from
52620de
to
6d560f7
Compare
|
I have updated this to include the a width adjustment for
construction=tertiary_link at the relevant zoom level, after #3570 was
merged, adding tertiary_link width to rendering.
…On Tue, Dec 25, 2018 at 7:13 PM Tomasz Wójcik ***@***.***> wrote:
@jeisenbe <https://github.com/jeisenbe> If you figure something out, you
can post it in #2872
<#2872>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3580 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AoxshJQ8JLyGbmPDBp1TdT4nPBAq2sZ3ks5u8fo3gaJpZM4ZZox6>
.
|
Okay, got it.
The reason is that currently we avoid yet to make a “best guess” in the code for road rendering. Example: For normal roads (no construction) with Now, semantically, So, for reasons of consistency, |
|
I thought that too, at first, but then I realized that many mappers use
just highway=construction without additional classification. This is
relatively much more common than highway=road.
The renderings did not work well with the width and light gray of
highway=road. The current commit is a less dramatic change from the current
rendering, and looks more harmonious with the other types of construction=*
…On Thu, Dec 27, 2018 at 7:14 PM Lukas Sommer ***@***.***> wrote:
The current PR does render construction=road and construction=residential
differently, as shown in the test renderings above. The change was for
highway=construction without any additional tags.
Okay, got it.
highway=construction without any additional tags should render like
highway=construction with construction=road.
The reason is that currently we avoid yet to make a “best guess” in the
code for road rendering. Example: For normal roads (no construction) with
highway=road, we render them differently from residential or unclassified.
Indeed we could also just “guess” that it is likely that they are
residential or unclassified and render them like that. But we don’t
because we want to give the mapper the feedback that he should use a more
specific value than road.
Now, semantically, highway=construction without any additional tags is
the same thing as highway=construction with construction=road: In both
cases, there is a lack of information about the road type.
So, for reasons of consistency, highway=construction without any
additional tags should render like highway=construction with
construction=road.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3580 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AoxshBVgWcPUf4wMmai8t8fl4nz4fXPHks5u9J1rgaJpZM4ZZox6>
.
|
Maybe, but that’s not a good argument to treat it differently. Especially as your PR provides the much nicer rendering for these cases as the current one. |
|
sent from a phone
On 27. Dec 2018, at 12:18, jeisenbe ***@***.***> wrote:
I thought that too, at first, but then I realized that many mappers use
just highway=construction without additional classification. This is
relatively much more common than highway=road.
it is something different, highway=road is kind of a fixme (no road class), highway=construction is for roads under construction
|
|
@matthijsmelissen could you take a look at this one? I believe it is ready to merge as-is, but I'd also be happy to change the rendering for generic highway=construction if needed. |
|
Thanks, great work! |
I don't quite understand this comment, I don't think the new rendering is "much nicer", though it is a minor improvement. Currently highway=construction is rendered the same as construction=residential, and it uses a blue-gray dash pattern. This PR will change both highway=construction and construction=residential to render a little thinner at z14, z15 and z16 to match highway=residential, but the width is unchanged at <= z13 and >= z17. The color of the dashes is changed from blue-gray to neutral gray. But I would be very happy to make more extensive changes to the current highway=construction rendering, in a future PR, since there are still outstanding issues with this rendering. Please comment on #3579 |
Well, you’ve changed the colour from blue-ish to grey-ish, and that’s good! |
Fixes #2595
Changes proposed in this pull request:
Explanation:
There are several issues with the current highway=construction rendering. This PR addresses several:
There are several issues that this PR does not address, which will be discussed in #3579
I previously attempted to match the width of all roads at all zoom levels to their construction=* counterpart. However, the wider major roads at low zoom levels do not look right. Extensive adjustments would be needed to the dash pattern length, casing, and layering.
Dashed white and colored lines are quite prominent. This is problem is reduced currently, because highway=construction is rendered much narrower than major highways. Highway=construction does not follow proper layering order. Link roads (eg construction=motorway_link) can render on top of construction=motorway, and minor highways sometimes render on to of major highways. The layering order will sometimes reverse between different zoom levels. This is much more apparent if the roads are significantly wider.
These issues would need to be addressed before trying to match the width to wider roads at high zoom levels. But I believe this PR is a good start.
Test rendering:
z12 Before
After
z13
Before
After
z14 Before
After
z15 Before
After
z16 Before
After
z17 Before
After
Link roads z16 before
After